Cdot XB PointStream → 0.7

Comments and changes to this ticket

• 

  aSydiK March 29th, 2011 @ 10:47 PM

  • State changed from “assigned” to “review-requested”

  (from [09772fc31ca575befebfb5da402a074d31656e0c]) [#104 state:review-requested] added file specs and comments (more comments to be added later) https://github.com/aSydiK/XB-PointStream/commit/09772fc31ca575befeb...

• 

  Andor Salga April 2nd, 2011 @ 03:40 PM

  • State changed from “review-requested” to “review-needs-work”

  I was hoping you could provide more details.

  For example, for the following snippet there are a bunch of magic numbers and the
  block doesn't have thorough documentation, only that it parses normals.

  nzsign = ((ivalue >> 22) & 0x0001);
  nx11bits = ((ivalue) & 0x07ff);
  ny11bits = ((ivalue >> 11) & 0x07ff);
                
  if(nx11bits >= 0 && nx11bits < 2048){
    if(ny11bits >= 0 && ny11bits < 2048){
  

  I think you have a wealth of information you could be providing in this file
  for the next person who works on it.

• 

  aSydiK April 5th, 2011 @ 07:38 PM

  I'll add more documentation... however, specifically for that block, it's exactly what I retrieved from Arius3D's PSIReader. Aside from the obvious bit-shifting, there's not much more to tell about the logic behind it. It is how they deciphered their normals though.

• 

  Andor Salga April 5th, 2011 @ 07:45 PM

  :D wow. Okay, we'll have to talk to them about it then.

  Yes, please add whatever details. Even if they seem trivial to you like: "PSI files and ASCII and binary..."

• 

  aSydiK April 6th, 2011 @ 09:01 PM

  • State changed from “review-needs-work” to “review-requested”

  (from [87739b0accb82f51f68a0ba92aa194cb073a0a09]) [#104 state:review-requested] added more comments throughout the file https://github.com/aSydiK/XB-PointStream/commit/87739b0accb82f51f68...

• 

  Andor Salga April 20th, 2011 @ 01:13 AM

  • State changed from “review-requested” to “staged”
• 

  Andor Salga July 25th, 2011 @ 02:36 PM

  • State changed from “staged” to “checked-in”
  • Milestone order changed from “4” to “0”