Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

There was a problem

You must be a member of this account.

Add file specification details to PSI parser file

#104

The PSI parser file needs to have PSI specification details.

Reported by Andor Salga · March 26th, 2011 @ 07:53 PM

State: checked-in
Milestone: 0.7
Assigned to: aSydiK aSydiK

Activity

  1. aSydiK
    aSydiK
    • State changed from assigned to review-requested

    March 29th, 2011 @ 10:47 PM

  2. Andor Salga
    Andor Salga
    • State changed from review-requested to review-needs-work

    I was hoping you could provide more details.

    For example, for the following snippet there are a bunch of magic numbers and the
    block doesn't have thorough documentation, only that it parses normals.

    nzsign = ((ivalue >> 22) & 0x0001);
nx11bits = ((ivalue) & 0x07ff);
ny11bits = ((ivalue >> 11) & 0x07ff);
              
if(nx11bits >= 0 && nx11bits < 2048){
  if(ny11bits >= 0 && ny11bits < 2048){

    I think you have a wealth of information you could be providing in this file
    for the next person who works on it.

    April 2nd, 2011 @ 03:40 PM

  3. aSydiK
    aSydiK

    I'll add more documentation... however, specifically for that block, it's exactly what I retrieved from Arius3D's PSIReader. Aside from the obvious bit-shifting, there's not much more to tell about the logic behind it. It is how they deciphered their normals though.

    April 5th, 2011 @ 07:38 PM

  4. Andor Salga
    Andor Salga

    :D wow. Okay, we'll have to talk to them about it then.

    Yes, please add whatever details. Even if they seem trivial to you like: "PSI files and ASCII and binary..."

    April 5th, 2011 @ 07:45 PM

  5. aSydiK
    aSydiK
    • State changed from review-needs-work to review-requested

    April 6th, 2011 @ 09:01 PM

  6. Andor Salga
    Andor Salga
    • State changed from review-requested to staged

    April 20th, 2011 @ 01:13 AM

  7. Andor Salga
    Andor Salga
    • State changed from staged to checked-in
    • Milestone order changed from 4 to 0

    July 25th, 2011 @ 02:36 PM

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.