Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Fix normals for PSIParser

#99

Normals coming out of PSI files are currently incorrect.

Reported by aSydiK · March 23rd, 2011 @ 03:59 PM

State: checked-in
Milestone: 0.7
Assigned to: aSydiK aSydiK

Activity

  1. aSydiK
    aSydiK
    • Milestone set to 0.7
    • Milestone order changed from 16 to 0

    March 24th, 2011 @ 04:50 AM

  2. aSydiK
    aSydiK
    • State changed from assigned to review-requested

    March 29th, 2011 @ 10:30 PM

  3. aSydiK
    aSydiK

    Pulling #104 Add file specification details to PSI parser file will also result in the addition of the changes within this commit.

    March 29th, 2011 @ 10:48 PM

  4. Andor Salga
    Andor Salga
    • State changed from review-requested to review-needs-work

    There are a few issues with this patch. On Firefox, I almost never get any normal data from the parser. On Webkit, I get some data, but the numbers don't match.

    For example, I count 942,877 vertices but only 188,601 normals.

    To reproduce this:
    1) Comment the line which renders the point cloud in the psi parser test. This won't cause any problems when trying to render the out-of-sync VBOs.

    2) Add counters and do a console.log at the end of parseChunk, right before the parser calls the library back.

    April 2nd, 2011 @ 03:59 PM

  5. aSydiK
    aSydiK
    • State changed from review-needs-work to review-requested

    (from [4607a0ca2e08bff16b38165f43abbb9caf8f6f47]) [#99 Fix normals for PSIParser state:review-requested] fixed problem with not getting the same amount of normals as point information https://github.com/aSydiK/XB-PointStream/commit/4607a0ca2e08bff16b3...

    April 6th, 2011 @ 08:40 PM

  6. Andor Salga
    Andor Salga
    • State changed from review-requested to review-needs-work

    I still don't have equal counts. The interesting thing is there are exactly 5 times more vertices than normals.

    I count 942845 vertices
    and 188569 normals

    Any idea what this could be?

    April 6th, 2011 @ 09:48 PM

  7. aSydiK
    aSydiK
    • State changed from review-needs-work to review-requested

    April 11th, 2011 @ 08:21 PM

  8. Andor Salga
    Andor Salga
    • State changed from review-requested to under-review

    April 11th, 2011 @ 10:23 PM

  9. Andor Salga
    Andor Salga
    • Tag set to psi
    • State changed from under-review to staged

    Looks good!

    April 13th, 2011 @ 12:07 AM

  10. Andor Salga
    Andor Salga
    • State changed from staged to checked-in
    • Milestone order changed from 2 to 0

    July 25th, 2011 @ 02:36 PM

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.