Fix normals for PSIParser
-
aSydiK
- Milestone set to 0.7
- Milestone order changed from 16 to 0
-
aSydiK
- State changed from assigned to review-requested
(from [0bb7090ca38ba3760c477673ac5ee0de76772d0c]) norms have been fixed and are producing the right values [#99 Fix normals for PSIParser state:review-requested] https://github.com/aSydiK/XB-PointStream/commit/0bb7090ca38ba3760c4...
-
aSydiK
Pulling #104 Add file specification details to PSI parser file will also result in the addition of the changes within this commit.
-
Andor Salga
- State changed from review-requested to review-needs-work
There are a few issues with this patch. On Firefox, I almost never get any normal data from the parser. On Webkit, I get some data, but the numbers don't match.
For example, I count 942,877 vertices but only 188,601 normals.
To reproduce this:
1) Comment the line which renders the point cloud in the psi parser test. This won't cause any problems when trying to render the out-of-sync VBOs.2) Add counters and do a console.log at the end of parseChunk, right before the parser calls the library back.
-
aSydiK
- State changed from review-needs-work to review-requested
(from [4607a0ca2e08bff16b38165f43abbb9caf8f6f47]) [#99 Fix normals for PSIParser state:review-requested] fixed problem with not getting the same amount of normals as point information https://github.com/aSydiK/XB-PointStream/commit/4607a0ca2e08bff16b3...
-
Andor Salga
- State changed from review-requested to review-needs-work
I still don't have equal counts. The interesting thing is there are exactly 5 times more vertices than normals.
I count 942845 vertices
and 188569 normalsAny idea what this could be?
-
aSydiK
- State changed from review-needs-work to review-requested
(from [afaf3ab5865e869f717fac506363458ba5b72b6b]) [#99 Fix normals for PSIParser state:review-requested] REALLY fixed the number points being passed to VBO https://github.com/aSydiK/XB-PointStream/commit/afaf3ab5865e869f717...
-
Andor Salga
- State changed from review-requested to under-review
-
Andor Salga
- State changed from staged to checked-in
- Milestone order changed from 2 to 0
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.