Leaking 'key' into the global scope
-
aSydiK- State changed from assigned to review-requested
(from [9dd3bad2bf4d969b1862c0ca19a1709d4a05bf88]) fixed key to work with new layout [#78 Leaking 'key' into the global scope state:review-requested] https://github.com/aSydiK/XB-PointStream/commit/9dd3bad2bf4d969b186...
-
aSydiK
I'm not exactly sure if this fixed it... however, I have a test called leakedKey and on the page window.key is alerted as an HTMLElement and not a number. Let me know if this is what you're looking for.
-
Andor Salga- State changed from review-requested to review-needs-work
Alerting 'key' should produce a JS error since it shouldn't exist in the user's script.
Maybe we can have the user's key press callback be passed in an argument?
-
aSydiK
- State changed from review-needs-work to review-requested
checked the example with today's minefield nightly... got an undefined for
function keyDown(){
document.getElementById('key').innerHTML = ps.key; alert(window.key); }so I think it's working as intended now?
-
Andor Salga
- State changed from review-requested to checked-in
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.