Leaking 'key' into the global scope
Reported by Andor Salga | November 27th, 2010 @ 10:40 PM | in 0.5 (closed)
It looks like 'key' is being leaked into the global scope.
We should probably change this to a getter.
Comments and changes to this ticket
-
aSydiK December 9th, 2010 @ 11:13 PM
- State changed from assigned to review-requested
(from [9dd3bad2bf4d969b1862c0ca19a1709d4a05bf88]) fixed key to work with new layout [#78 state:review-requested] https://github.com/aSydiK/XB-PointStream/commit/9dd3bad2bf4d969b186...
-
aSydiK December 9th, 2010 @ 11:15 PM
I'm not exactly sure if this fixed it... however, I have a test called leakedKey and on the page window.key is alerted as an HTMLElement and not a number. Let me know if this is what you're looking for.
-
Andor Salga December 28th, 2010 @ 10:17 PM
- State changed from review-requested to review-needs-work
Alerting 'key' should produce a JS error since it shouldn't exist in the user's script.
Maybe we can have the user's key press callback be passed in an argument?
-
aSydiK January 20th, 2011 @ 07:01 PM
- State changed from review-needs-work to review-requested
checked the example with today's minefield nightly... got an undefined for
function keyDown(){
document.getElementById('key').innerHTML = ps.key; alert(window.key); }so I think it's working as intended now?
-
Andor Salga February 9th, 2011 @ 10:56 PM
- State changed from review-requested to checked-in
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป
<b>XB PointStream</b> (working name)
A cross-browser JavaScript tool which will emulate Arius3D's PointStream viewer. It will be able to quickly render a large amount of point cloud data to the <canvas> tag using WebGL.<br />
Current release <a href="http://scotland.proximity.on.ca/asalga/releases/0.8/xbps-min-0.8.zip">XBPS 0.8</a>
People watching this ticket
Referenced by
- 78 Leaking 'key' into the global scope (from [9dd3bad2bf4d969b1862c0ca19a1709d4a05bf88]) fixed k...