Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

There was a problem

You must be a member of this account.

Fix 500 color/normal check

#93

I ran into a problem trying to load a .ASC file. I found out that it was because the parser had a problem trying to determine the contents of an .ASC file. For example:

1.0 0.0 0.0    1.0 0.0 0.0
0.0 1.0 0.0    0.0 1.0 0.0

The last set of triplets could either be normal or color data. The .ASC parser only checks the first 500 bytes. This needs to be updated to read the entire file.

Reported by Andor Salga · March 5th, 2011 @ 01:47 AM

State: checked-in
Milestone: 0.6
Assigned to: Andor Salga Andor Salga

Activity

  1. Andor Salga
    Andor Salga
    • State changed from assigned to review-requested

    I added some extra logic which fixed the problem. I added the case where if the values consistently add up to unit length 1, then these values are likely normal data rather than color data.

    Branch: https://github.com/asalga/XB-PointStream/tree/bug93
    Test: tests/asc_norm_vert_test

    We should probably not push the monnkey.asc file to trunk since it's rather large.

    March 6th, 2011 @ 08:26 PM

  2. Andor Salga
    Andor Salga
    • State changed from review-requested to staged

    March 14th, 2011 @ 05:46 PM

  3. Andor Salga
    Andor Salga
    • State changed from staged to checked-in

    March 27th, 2011 @ 07:07 PM

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.