Fix 500 color/normal check
Reported by Andor Salga | March 5th, 2011 @ 01:47 AM | in 0.6
I ran into a problem trying to load a .ASC file. I found out that it was because the parser had a problem trying to determine the contents of an .ASC file. For example:
1.0 0.0 0.0 1.0 0.0 0.0
0.0 1.0 0.0 0.0 1.0 0.0
The last set of triplets could either be normal or color data. The .ASC parser only checks the first 500 bytes. This needs to be updated to read the entire file.
Comments and changes to this ticket
-
Andor Salga March 6th, 2011 @ 08:26 PM
- State changed from “assigned” to “review-requested”
I added some extra logic which fixed the problem. I added the case where if the values consistently add up to unit length 1, then these values are likely normal data rather than color data.
Branch: https://github.com/asalga/XB-PointStream/tree/bug93
Test: tests/asc_norm_vert_testWe should probably not push the monnkey.asc file to trunk since it's rather large.
-
Andor Salga March 14th, 2011 @ 05:46 PM
- State changed from “review-requested” to “staged”
-
Andor Salga March 27th, 2011 @ 07:07 PM
- State changed from “staged” to “checked-in”
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป
<b>XB PointStream</b> (working name)
A cross-browser JavaScript tool which will emulate Arius3D's PointStream viewer. It will be able to quickly render a large amount of point cloud data to the <canvas> tag using WebGL.<br />
Current release <a href="http://scotland.proximity.on.ca/asalga/releases/0.8/xbps-min-0.8.zip">XBPS 0.8</a>
Andor Salga
Cathy